Loading...
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 | // SPDX-License-Identifier: GPL-2.0-only /// /// Check for opencoded min(), max() implementations. /// Generated patches sometimes require adding a cast to fix compile warning. /// Warnings/patches scope intentionally limited to a function body. /// // Confidence: Medium // Copyright: (C) 2021 Denis Efremov ISPRAS // Options: --no-includes --include-headers // // Keywords: min, max // virtual report virtual org virtual context virtual patch @rmax depends on !patch@ identifier func; expression x, y; binary operator cmp = {>, >=}; position p; @@ func(...) { <... * ((x) cmp@p (y) ? (x) : (y)) ...> } @rmaxif depends on !patch@ identifier func; expression x, y; expression max_val; binary operator cmp = {>, >=}; position p; @@ func(...) { <... * if ((x) cmp@p (y)) { * max_val = (x); * } else { * max_val = (y); * } ...> } @rmin depends on !patch@ identifier func; expression x, y; binary operator cmp = {<, <=}; position p; @@ func(...) { <... * ((x) cmp@p (y) ? (x) : (y)) ...> } @rminif depends on !patch@ identifier func; expression x, y; expression min_val; binary operator cmp = {<, <=}; position p; @@ func(...) { <... * if ((x) cmp@p (y)) { * min_val = (x); * } else { * min_val = (y); * } ...> } @pmax depends on patch@ identifier func; expression x, y; binary operator cmp = {>=, >}; @@ func(...) { <... - ((x) cmp (y) ? (x) : (y)) + max(x, y) ...> } @pmaxif depends on patch@ identifier func; expression x, y; expression max_val; binary operator cmp = {>=, >}; @@ func(...) { <... - if ((x) cmp (y)) { - max_val = x; - } else { - max_val = y; - } + max_val = max(x, y); ...> } // Don't generate patches for errcode returns. @errcode depends on patch@ position p; identifier func; expression x; binary operator cmp = {<, <=}; @@ func(...) { <... return ((x) cmp@p 0 ? (x) : 0); ...> } @pmin depends on patch@ identifier func; expression x, y; binary operator cmp = {<=, <}; position p != errcode.p; @@ func(...) { <... - ((x) cmp@p (y) ? (x) : (y)) + min(x, y) ...> } @pminif depends on patch@ identifier func; expression x, y; expression min_val; binary operator cmp = {<=, <}; @@ func(...) { <... - if ((x) cmp (y)) { - min_val = x; - } else { - min_val = y; - } + min_val = min(x, y); ...> } @script:python depends on report@ p << rmax.p; @@ for p0 in p: coccilib.report.print_report(p0, "WARNING opportunity for max()") @script:python depends on org@ p << rmax.p; @@ for p0 in p: coccilib.org.print_todo(p0, "WARNING opportunity for max()") @script:python depends on report@ p << rmaxif.p; @@ for p0 in p: coccilib.report.print_report(p0, "WARNING opportunity for max()") @script:python depends on org@ p << rmaxif.p; @@ for p0 in p: coccilib.org.print_todo(p0, "WARNING opportunity for max()") @script:python depends on report@ p << rmin.p; @@ for p0 in p: coccilib.report.print_report(p0, "WARNING opportunity for min()") @script:python depends on org@ p << rmin.p; @@ for p0 in p: coccilib.org.print_todo(p0, "WARNING opportunity for min()") @script:python depends on report@ p << rminif.p; @@ for p0 in p: coccilib.report.print_report(p0, "WARNING opportunity for min()") @script:python depends on org@ p << rminif.p; @@ for p0 in p: coccilib.org.print_todo(p0, "WARNING opportunity for min()") |