Loading...
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 | // SPDX-License-Identifier: GPL-2.0 /* Copyright (c) 2022 Facebook */ #include <errno.h> #include <string.h> #include <linux/bpf.h> #include <bpf/bpf_helpers.h> #include "bpf_misc.h" char _license[] SEC("license") = "GPL"; #define ITER_HELPERS \ __imm(bpf_iter_num_new), \ __imm(bpf_iter_num_next), \ __imm(bpf_iter_num_destroy) SEC("?raw_tp") __success int force_clang_to_emit_btf_for_externs(void *ctx) { /* we need this as a workaround to enforce compiler emitting BTF * information for bpf_iter_num_{new,next,destroy}() kfuncs, * as, apparently, it doesn't emit it for symbols only referenced from * assembly (or cleanup attribute, for that matter, as well) */ bpf_repeat(0); return 0; } SEC("?raw_tp") __success __log_level(2) __msg("fp-8_w=iter_num(ref_id=1,state=active,depth=0)") int create_and_destroy(void *ctx) { struct bpf_iter_num iter; asm volatile ( /* create iterator */ "r1 = %[iter];" "r2 = 0;" "r3 = 1000;" "call %[bpf_iter_num_new];" /* destroy iterator */ "r1 = %[iter];" "call %[bpf_iter_num_destroy];" : : __imm_ptr(iter), ITER_HELPERS : __clobber_common ); return 0; } SEC("?raw_tp") __failure __msg("Unreleased reference id=1") int create_and_forget_to_destroy_fail(void *ctx) { struct bpf_iter_num iter; asm volatile ( /* create iterator */ "r1 = %[iter];" "r2 = 0;" "r3 = 1000;" "call %[bpf_iter_num_new];" : : __imm_ptr(iter), ITER_HELPERS : __clobber_common ); return 0; } SEC("?raw_tp") __failure __msg("expected an initialized iter_num as arg #1") int destroy_without_creating_fail(void *ctx) { /* init with zeros to stop verifier complaining about uninit stack */ struct bpf_iter_num iter; asm volatile ( "r1 = %[iter];" "call %[bpf_iter_num_destroy];" : : __imm_ptr(iter), ITER_HELPERS : __clobber_common ); return 0; } SEC("?raw_tp") __failure __msg("expected an initialized iter_num as arg #1") int compromise_iter_w_direct_write_fail(void *ctx) { struct bpf_iter_num iter; asm volatile ( /* create iterator */ "r1 = %[iter];" "r2 = 0;" "r3 = 1000;" "call %[bpf_iter_num_new];" /* directly write over first half of iter state */ "*(u64 *)(%[iter] + 0) = r0;" /* (attempt to) destroy iterator */ "r1 = %[iter];" "call %[bpf_iter_num_destroy];" : : __imm_ptr(iter), ITER_HELPERS : __clobber_common ); return 0; } SEC("?raw_tp") __failure __msg("Unreleased reference id=1") int compromise_iter_w_direct_write_and_skip_destroy_fail(void *ctx) { struct bpf_iter_num iter; asm volatile ( /* create iterator */ "r1 = %[iter];" "r2 = 0;" "r3 = 1000;" "call %[bpf_iter_num_new];" /* directly write over first half of iter state */ "*(u64 *)(%[iter] + 0) = r0;" /* don't destroy iter, leaking ref, which should fail */ : : __imm_ptr(iter), ITER_HELPERS : __clobber_common ); return 0; } SEC("?raw_tp") __failure __msg("expected an initialized iter_num as arg #1") int compromise_iter_w_helper_write_fail(void *ctx) { struct bpf_iter_num iter; asm volatile ( /* create iterator */ "r1 = %[iter];" "r2 = 0;" "r3 = 1000;" "call %[bpf_iter_num_new];" /* overwrite 8th byte with bpf_probe_read_kernel() */ "r1 = %[iter];" "r1 += 7;" "r2 = 1;" "r3 = 0;" /* NULL */ "call %[bpf_probe_read_kernel];" /* (attempt to) destroy iterator */ "r1 = %[iter];" "call %[bpf_iter_num_destroy];" : : __imm_ptr(iter), ITER_HELPERS, __imm(bpf_probe_read_kernel) : __clobber_common ); return 0; } static __noinline void subprog_with_iter(void) { struct bpf_iter_num iter; bpf_iter_num_new(&iter, 0, 1); return; } SEC("?raw_tp") __failure /* ensure there was a call to subprog, which might happen without __noinline */ __msg("returning from callee:") __msg("Unreleased reference id=1") int leak_iter_from_subprog_fail(void *ctx) { subprog_with_iter(); return 0; } SEC("?raw_tp") __success __log_level(2) __msg("fp-8_w=iter_num(ref_id=1,state=active,depth=0)") int valid_stack_reuse(void *ctx) { struct bpf_iter_num iter; asm volatile ( /* create iterator */ "r1 = %[iter];" "r2 = 0;" "r3 = 1000;" "call %[bpf_iter_num_new];" /* destroy iterator */ "r1 = %[iter];" "call %[bpf_iter_num_destroy];" /* now reuse same stack slots */ /* create iterator */ "r1 = %[iter];" "r2 = 0;" "r3 = 1000;" "call %[bpf_iter_num_new];" /* destroy iterator */ "r1 = %[iter];" "call %[bpf_iter_num_destroy];" : : __imm_ptr(iter), ITER_HELPERS : __clobber_common ); return 0; } SEC("?raw_tp") __failure __msg("expected uninitialized iter_num as arg #1") int double_create_fail(void *ctx) { struct bpf_iter_num iter; asm volatile ( /* create iterator */ "r1 = %[iter];" "r2 = 0;" "r3 = 1000;" "call %[bpf_iter_num_new];" /* (attempt to) create iterator again */ "r1 = %[iter];" "r2 = 0;" "r3 = 1000;" "call %[bpf_iter_num_new];" /* destroy iterator */ "r1 = %[iter];" "call %[bpf_iter_num_destroy];" : : __imm_ptr(iter), ITER_HELPERS : __clobber_common ); return 0; } SEC("?raw_tp") __failure __msg("expected an initialized iter_num as arg #1") int double_destroy_fail(void *ctx) { struct bpf_iter_num iter; asm volatile ( /* create iterator */ "r1 = %[iter];" "r2 = 0;" "r3 = 1000;" "call %[bpf_iter_num_new];" /* destroy iterator */ "r1 = %[iter];" "call %[bpf_iter_num_destroy];" /* (attempt to) destroy iterator again */ "r1 = %[iter];" "call %[bpf_iter_num_destroy];" : : __imm_ptr(iter), ITER_HELPERS : __clobber_common ); return 0; } SEC("?raw_tp") __failure __msg("expected an initialized iter_num as arg #1") int next_without_new_fail(void *ctx) { struct bpf_iter_num iter; asm volatile ( /* don't create iterator and try to iterate*/ "r1 = %[iter];" "call %[bpf_iter_num_next];" /* destroy iterator */ "r1 = %[iter];" "call %[bpf_iter_num_destroy];" : : __imm_ptr(iter), ITER_HELPERS : __clobber_common ); return 0; } SEC("?raw_tp") __failure __msg("expected an initialized iter_num as arg #1") int next_after_destroy_fail(void *ctx) { struct bpf_iter_num iter; asm volatile ( /* create iterator */ "r1 = %[iter];" "r2 = 0;" "r3 = 1000;" "call %[bpf_iter_num_new];" /* destroy iterator */ "r1 = %[iter];" "call %[bpf_iter_num_destroy];" /* don't create iterator and try to iterate*/ "r1 = %[iter];" "call %[bpf_iter_num_next];" : : __imm_ptr(iter), ITER_HELPERS : __clobber_common ); return 0; } SEC("?raw_tp") __failure __msg("invalid read from stack") int __naked read_from_iter_slot_fail(void) { asm volatile ( /* r6 points to struct bpf_iter_num on the stack */ "r6 = r10;" "r6 += -24;" /* create iterator */ "r1 = r6;" "r2 = 0;" "r3 = 1000;" "call %[bpf_iter_num_new];" /* attemp to leak bpf_iter_num state */ "r7 = *(u64 *)(r6 + 0);" "r8 = *(u64 *)(r6 + 8);" /* destroy iterator */ "r1 = r6;" "call %[bpf_iter_num_destroy];" /* leak bpf_iter_num state */ "r0 = r7;" "if r7 > r8 goto +1;" "r0 = r8;" "exit;" : : ITER_HELPERS : __clobber_common, "r6", "r7", "r8" ); } int zero; SEC("?raw_tp") __failure __flag(BPF_F_TEST_STATE_FREQ) __msg("Unreleased reference") int stacksafe_should_not_conflate_stack_spill_and_iter(void *ctx) { struct bpf_iter_num iter; asm volatile ( /* Create a fork in logic, with general setup as follows: * - fallthrough (first) path is valid; * - branch (second) path is invalid. * Then depending on what we do in fallthrough vs branch path, * we try to detect bugs in func_states_equal(), regsafe(), * refsafe(), stack_safe(), and similar by tricking verifier * into believing that branch state is a valid subset of * a fallthrough state. Verifier should reject overall * validation, unless there is a bug somewhere in verifier * logic. */ "call %[bpf_get_prandom_u32];" "r6 = r0;" "call %[bpf_get_prandom_u32];" "r7 = r0;" "if r6 > r7 goto bad;" /* fork */ /* spill r6 into stack slot of bpf_iter_num var */ "*(u64 *)(%[iter] + 0) = r6;" "goto skip_bad;" "bad:" /* create iterator in the same stack slot */ "r1 = %[iter];" "r2 = 0;" "r3 = 1000;" "call %[bpf_iter_num_new];" /* but then forget about it and overwrite it back to r6 spill */ "*(u64 *)(%[iter] + 0) = r6;" "skip_bad:" "goto +0;" /* force checkpoint */ /* corrupt stack slots, if they are really dynptr */ "*(u64 *)(%[iter] + 0) = r6;" : : __imm_ptr(iter), __imm_addr(zero), __imm(bpf_get_prandom_u32), __imm(bpf_dynptr_from_mem), ITER_HELPERS : __clobber_common, "r6", "r7" ); return 0; } |