Loading...
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 | // SPDX-License-Identifier: GPL-2.0-only /// /// Check for array_size(), array3_size(), struct_size() duplicates. /// These patterns are detected: /// 1. An opencoded expression is used before array_size() to compute the same size /// 2. An opencoded expression is used after array_size() to compute the same size /// From security point of view only first case is relevant. These functions /// perform arithmetic overflow check. Thus, if we use an opencoded expression /// before a call to the *_size() function we can miss an overflow. /// // Confidence: High // Copyright: (C) 2020 Denis Efremov ISPRAS // Options: --no-includes --include-headers --no-loops virtual context virtual report virtual org @as@ expression E1, E2; @@ array_size(E1, E2) @as_next@ expression subE1 <= as.E1; expression subE2 <= as.E2; expression as.E1, as.E2, E3; assignment operator aop; position p1, p2; @@ * E1 * E2@p1 ... when != \(subE1\|subE2\) aop E3 when != &\(subE1\|subE2\) * array_size(E1, E2)@p2 @script:python depends on report@ p1 << as_next.p1; p2 << as_next.p2; @@ msg = "WARNING: array_size is used later (line %s) to compute the same size" % (p2[0].line) coccilib.report.print_report(p1[0], msg) @script:python depends on org@ p1 << as_next.p1; p2 << as_next.p2; @@ msg = "WARNING: array_size is used later (line %s) to compute the same size" % (p2[0].line) coccilib.org.print_todo(p1[0], msg) @as_prev@ expression subE1 <= as.E1; expression subE2 <= as.E2; expression as.E1, as.E2, E3; assignment operator aop; position p1, p2; @@ * array_size(E1, E2)@p1 ... when != \(subE1\|subE2\) aop E3 when != &\(subE1\|subE2\) * E1 * E2@p2 @script:python depends on report@ p1 << as_prev.p1; p2 << as_prev.p2; @@ msg = "WARNING: array_size is already used (line %s) to compute the same size" % (p1[0].line) coccilib.report.print_report(p2[0], msg) @script:python depends on org@ p1 << as_prev.p1; p2 << as_prev.p2; @@ msg = "WARNING: array_size is already used (line %s) to compute the same size" % (p1[0].line) coccilib.org.print_todo(p2[0], msg) @as3@ expression E1, E2, E3; @@ array3_size(E1, E2, E3) @as3_next@ expression subE1 <= as3.E1; expression subE2 <= as3.E2; expression subE3 <= as3.E3; expression as3.E1, as3.E2, as3.E3, E4; assignment operator aop; position p1, p2; @@ * E1 * E2 * E3@p1 ... when != \(subE1\|subE2\|subE3\) aop E4 when != &\(subE1\|subE2\|subE3\) * array3_size(E1, E2, E3)@p2 @script:python depends on report@ p1 << as3_next.p1; p2 << as3_next.p2; @@ msg = "WARNING: array3_size is used later (line %s) to compute the same size" % (p2[0].line) coccilib.report.print_report(p1[0], msg) @script:python depends on org@ p1 << as3_next.p1; p2 << as3_next.p2; @@ msg = "WARNING: array3_size is used later (line %s) to compute the same size" % (p2[0].line) coccilib.org.print_todo(p1[0], msg) @as3_prev@ expression subE1 <= as3.E1; expression subE2 <= as3.E2; expression subE3 <= as3.E3; expression as3.E1, as3.E2, as3.E3, E4; assignment operator aop; position p1, p2; @@ * array3_size(E1, E2, E3)@p1 ... when != \(subE1\|subE2\|subE3\) aop E4 when != &\(subE1\|subE2\|subE3\) * E1 * E2 * E3@p2 @script:python depends on report@ p1 << as3_prev.p1; p2 << as3_prev.p2; @@ msg = "WARNING: array3_size is already used (line %s) to compute the same size" % (p1[0].line) coccilib.report.print_report(p2[0], msg) @script:python depends on org@ p1 << as3_prev.p1; p2 << as3_prev.p2; @@ msg = "WARNING: array3_size is already used (line %s) to compute the same size" % (p1[0].line) coccilib.org.print_todo(p2[0], msg) @ss@ expression E1, E2, E3; @@ struct_size(E1, E2, E3) @ss_next@ expression subE3 <= ss.E3; expression ss.E1, ss.E2, ss.E3, E4; assignment operator aop; position p1, p2; @@ * E1 * E2 + E3@p1 ... when != subE3 aop E4 when != &subE3 * struct_size(E1, E2, E3)@p2 @script:python depends on report@ p1 << ss_next.p1; p2 << ss_next.p2; @@ msg = "WARNING: struct_size is used later (line %s) to compute the same size" % (p2[0].line) coccilib.report.print_report(p1[0], msg) @script:python depends on org@ p1 << ss_next.p1; p2 << ss_next.p2; @@ msg = "WARNING: struct_size is used later (line %s) to compute the same size" % (p2[0].line) coccilib.org.print_todo(p1[0], msg) @ss_prev@ expression subE3 <= ss.E3; expression ss.E1, ss.E2, ss.E3, E4; assignment operator aop; position p1, p2; @@ * struct_size(E1, E2, E3)@p1 ... when != subE3 aop E4 when != &subE3 * E1 * E2 + E3@p2 @script:python depends on report@ p1 << ss_prev.p1; p2 << ss_prev.p2; @@ msg = "WARNING: struct_size is already used (line %s) to compute the same size" % (p1[0].line) coccilib.report.print_report(p2[0], msg) @script:python depends on org@ p1 << ss_prev.p1; p2 << ss_prev.p2; @@ msg = "WARNING: struct_size is already used (line %s) to compute the same size" % (p1[0].line) coccilib.org.print_todo(p2[0], msg) |