Loading...
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 | // SPDX-License-Identifier: GPL-2.0-only /// /// Use zeroing allocator rather than allocator followed by memset with 0 /// /// This considers some simple cases that are common and easy to validate /// Note in particular that there are no ...s in the rule, so all of the /// matched code has to be contiguous /// // Confidence: High // Copyright: (C) 2009-2010 Julia Lawall, Nicolas Palix, DIKU. // Copyright: (C) 2009-2010 Gilles Muller, INRIA/LiP6. // Copyright: (C) 2017 Himanshu Jha // URL: https://coccinelle.gitlabpages.inria.fr/website // Options: --no-includes --include-headers // // Keywords: kmalloc, kzalloc // Version min: < 2.6.12 kmalloc // Version min: 2.6.14 kzalloc // virtual context virtual patch virtual org virtual report //---------------------------------------------------------- // For context mode //---------------------------------------------------------- @depends on context@ type T, T2; expression x; expression E1; statement S; @@ * x = (T)\(kmalloc(E1, ...)\|vmalloc(E1)\|dma_alloc_coherent(...,E1,...)\| kmalloc_node(E1, ...)\|kmem_cache_alloc(...)\|kmem_alloc(E1, ...)\| devm_kmalloc(...,E1,...)\|kvmalloc(E1, ...)\|kvmalloc_node(E1,...)\); if ((x==NULL) || ...) S * memset((T2)x,0,E1); //---------------------------------------------------------- // For patch mode //---------------------------------------------------------- @depends on patch@ type T, T2; expression x; expression E1,E2,E3,E4; statement S; @@ ( - x = kmalloc(E1,E2); + x = kzalloc(E1,E2); | - x = (T *)kmalloc(E1,E2); + x = kzalloc(E1,E2); | - x = (T)kmalloc(E1,E2); + x = (T)kzalloc(E1,E2); | - x = vmalloc(E1); + x = vzalloc(E1); | - x = (T *)vmalloc(E1); + x = vzalloc(E1); | - x = (T)vmalloc(E1); + x = (T)vzalloc(E1); | - x = kmalloc_node(E1,E2,E3); + x = kzalloc_node(E1,E2,E3); | - x = (T *)kmalloc_node(E1,E2,E3); + x = kzalloc_node(E1,E2,E3); | - x = (T)kmalloc_node(E1,E2,E3); + x = (T)kzalloc_node(E1,E2,E3); | - x = kmem_cache_alloc(E3,E4); + x = kmem_cache_zalloc(E3,E4); | - x = (T *)kmem_cache_alloc(E3,E4); + x = kmem_cache_zalloc(E3,E4); | - x = (T)kmem_cache_alloc(E3,E4); + x = (T)kmem_cache_zalloc(E3,E4); | - x = kmem_alloc(E1,E2); + x = kmem_zalloc(E1,E2); | - x = (T *)kmem_alloc(E1,E2); + x = kmem_zalloc(E1,E2); | - x = (T)kmem_alloc(E1,E2); + x = (T)kmem_zalloc(E1,E2); | - x = devm_kmalloc(E2,E1,E3); + x = devm_kzalloc(E2,E1,E3); | - x = (T *)devm_kmalloc(E2,E1,E3); + x = devm_kzalloc(E2,E1,E3); | - x = (T)devm_kmalloc(E2,E1,E3); + x = (T)devm_kzalloc(E2,E1,E3); | - x = kvmalloc(E1,E2); + x = kvzalloc(E1,E2); | - x = (T *)kvmalloc(E1,E2); + x = kvzalloc(E1,E2); | - x = (T)kvmalloc(E1,E2); + x = (T)kvzalloc(E1,E2); | - x = kvmalloc_node(E1,E2,E3); + x = kvzalloc_node(E1,E2,E3); | - x = (T *)kvmalloc_node(E1,E2,E3); + x = kvzalloc_node(E1,E2,E3); | - x = (T)kvmalloc_node(E1,E2,E3); + x = (T)kvzalloc_node(E1,E2,E3); ) if ((x==NULL) || ...) S - memset((T2)x,0,E1); @depends on patch@ type T, T2; expression x; expression E1,E2,E3,E4; statement S; @@ x = (T)dma_alloc_coherent(E1, E2, E3, E4); if ((x==NULL) || ...) S - memset((T2)x, 0, E2); //---------------------------------------------------------- // For org mode //---------------------------------------------------------- @r depends on org || report@ type T, T2; expression x; expression E1,E2; statement S; position p; @@ x = (T)kmalloc@p(E1,E2); if ((x==NULL) || ...) S memset((T2)x,0,E1); @script:python depends on org@ p << r.p; x << r.x; @@ msg="%s" % (x) msg_safe=msg.replace("[","@(").replace("]",")") coccilib.org.print_todo(p[0], msg_safe) @script:python depends on report@ p << r.p; x << r.x; @@ msg="WARNING: kzalloc should be used for %s, instead of kmalloc/memset" % (x) coccilib.report.print_report(p[0], msg) //----------------------------------------------------------------- @r1 depends on org || report@ type T, T2; expression x; expression E1; statement S; position p; @@ x = (T)vmalloc@p(E1); if ((x==NULL) || ...) S memset((T2)x,0,E1); @script:python depends on org@ p << r1.p; x << r1.x; @@ msg="%s" % (x) msg_safe=msg.replace("[","@(").replace("]",")") coccilib.org.print_todo(p[0], msg_safe) @script:python depends on report@ p << r1.p; x << r1.x; @@ msg="WARNING: vzalloc should be used for %s, instead of vmalloc/memset" % (x) coccilib.report.print_report(p[0], msg) //----------------------------------------------------------------- @r2 depends on org || report@ type T, T2; expression x; expression E1,E2,E3,E4; statement S; position p; @@ x = (T)dma_alloc_coherent@p(E1,E2,E3,E4); if ((x==NULL) || ...) S memset((T2)x,0,E2); @script:python depends on org@ p << r2.p; x << r2.x; @@ msg="%s" % (x) msg_safe=msg.replace("[","@(").replace("]",")") coccilib.org.print_todo(p[0], msg_safe) @script:python depends on report@ p << r2.p; x << r2.x; @@ msg="WARNING: dma_alloc_coherent used in %s already zeroes out memory, so memset is not needed" % (x) coccilib.report.print_report(p[0], msg) //----------------------------------------------------------------- @r3 depends on org || report@ type T, T2; expression x; expression E1,E2,E3; statement S; position p; @@ x = (T)kmalloc_node@p(E1,E2,E3); if ((x==NULL) || ...) S memset((T2)x,0,E1); @script:python depends on org@ p << r3.p; x << r3.x; @@ msg="%s" % (x) msg_safe=msg.replace("[","@(").replace("]",")") coccilib.org.print_todo(p[0], msg_safe) @script:python depends on report@ p << r3.p; x << r3.x; @@ msg="WARNING: kzalloc_node should be used for %s, instead of kmalloc_node/memset" % (x) coccilib.report.print_report(p[0], msg) //----------------------------------------------------------------- @r4 depends on org || report@ type T, T2; expression x; expression E1,E2,E3; statement S; position p; @@ x = (T)kmem_cache_alloc@p(E2,E3); if ((x==NULL) || ...) S memset((T2)x,0,E1); @script:python depends on org@ p << r4.p; x << r4.x; @@ msg="%s" % (x) msg_safe=msg.replace("[","@(").replace("]",")") coccilib.org.print_todo(p[0], msg_safe) @script:python depends on report@ p << r4.p; x << r4.x; @@ msg="WARNING: kmem_cache_zalloc should be used for %s, instead of kmem_cache_alloc/memset" % (x) coccilib.report.print_report(p[0], msg) //----------------------------------------------------------------- @r5 depends on org || report@ type T, T2; expression x; expression E1,E2; statement S; position p; @@ x = (T)kmem_alloc@p(E1,E2); if ((x==NULL) || ...) S memset((T2)x,0,E1); @script:python depends on org@ p << r5.p; x << r5.x; @@ msg="%s" % (x) msg_safe=msg.replace("[","@(").replace("]",")") coccilib.org.print_todo(p[0], msg_safe) @script:python depends on report@ p << r5.p; x << r5.x; @@ msg="WARNING: kmem_zalloc should be used for %s, instead of kmem_alloc/memset" % (x) coccilib.report.print_report(p[0], msg) //----------------------------------------------------------------- @r6 depends on org || report@ type T, T2; expression x; expression E1,E2,E3; statement S; position p; @@ x = (T)devm_kmalloc@p(E2,E1,E3); if ((x==NULL) || ...) S memset((T2)x,0,E1); @script:python depends on org@ p << r6.p; x << r6.x; @@ msg="%s" % (x) msg_safe=msg.replace("[","@(").replace("]",")") coccilib.org.print_todo(p[0], msg_safe) @script:python depends on report@ p << r6.p; x << r6.x; @@ msg="WARNING: devm_kzalloc should be used for %s, instead of devm_kmalloc/memset" % (x) coccilib.report.print_report(p[0], msg) //----------------------------------------------------------------- @r7 depends on org || report@ type T, T2; expression x; expression E1,E2; statement S; position p; @@ x = (T)kvmalloc@p(E1,E2); if ((x==NULL) || ...) S memset((T2)x,0,E1); @script:python depends on org@ p << r7.p; x << r7.x; @@ msg="%s" % (x) msg_safe=msg.replace("[","@(").replace("]",")") coccilib.org.print_todo(p[0], msg_safe) @script:python depends on report@ p << r7.p; x << r7.x; @@ msg="WARNING: kvzalloc should be used for %s, instead of kvmalloc/memset" % (x) coccilib.report.print_report(p[0], msg) //----------------------------------------------------------------- @r9 depends on org || report@ type T, T2; expression x; expression E1,E2,E3; statement S; position p; @@ x = (T)kvmalloc_node@p(E1,E2,E3); if ((x==NULL) || ...) S memset((T2)x,0,E1); @script:python depends on org@ p << r9.p; x << r9.x; @@ msg="%s" % (x) msg_safe=msg.replace("[","@(").replace("]",")") coccilib.org.print_todo(p[0], msg_safe) @script:python depends on report@ p << r9.p; x << r9.x; @@ msg="WARNING: kvzalloc_node should be used for %s, instead of kvmalloc_node/memset" % (x) coccilib.report.print_report(p[0], msg) |