Loading...
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 | // SPDX-License-Identifier: GPL-2.0 /* Copyright (c) 2022 Facebook */ #include <errno.h> #include <string.h> #include <stdbool.h> #include <linux/bpf.h> #include <bpf/bpf_helpers.h> #include <linux/if_ether.h> #include "bpf_misc.h" #include "bpf_kfuncs.h" char _license[] SEC("license") = "GPL"; struct test_info { int x; struct bpf_dynptr ptr; }; struct { __uint(type, BPF_MAP_TYPE_ARRAY); __uint(max_entries, 1); __type(key, __u32); __type(value, struct bpf_dynptr); } array_map1 SEC(".maps"); struct { __uint(type, BPF_MAP_TYPE_ARRAY); __uint(max_entries, 1); __type(key, __u32); __type(value, struct test_info); } array_map2 SEC(".maps"); struct { __uint(type, BPF_MAP_TYPE_ARRAY); __uint(max_entries, 1); __type(key, __u32); __type(value, __u32); } array_map3 SEC(".maps"); struct { __uint(type, BPF_MAP_TYPE_ARRAY); __uint(max_entries, 1); __type(key, __u32); __type(value, __u64); } array_map4 SEC(".maps"); struct sample { int pid; long value; char comm[16]; }; struct { __uint(type, BPF_MAP_TYPE_RINGBUF); __uint(max_entries, 4096); } ringbuf SEC(".maps"); int err, val; static int get_map_val_dynptr(struct bpf_dynptr *ptr) { __u32 key = 0, *map_val; bpf_map_update_elem(&array_map3, &key, &val, 0); map_val = bpf_map_lookup_elem(&array_map3, &key); if (!map_val) return -ENOENT; bpf_dynptr_from_mem(map_val, sizeof(*map_val), 0, ptr); return 0; } /* Every bpf_ringbuf_reserve_dynptr call must have a corresponding * bpf_ringbuf_submit/discard_dynptr call */ SEC("?raw_tp") __failure __msg("Unreleased reference id=2") int ringbuf_missing_release1(void *ctx) { struct bpf_dynptr ptr = {}; bpf_ringbuf_reserve_dynptr(&ringbuf, val, 0, &ptr); /* missing a call to bpf_ringbuf_discard/submit_dynptr */ return 0; } SEC("?raw_tp") __failure __msg("Unreleased reference id=4") int ringbuf_missing_release2(void *ctx) { struct bpf_dynptr ptr1, ptr2; struct sample *sample; bpf_ringbuf_reserve_dynptr(&ringbuf, sizeof(*sample), 0, &ptr1); bpf_ringbuf_reserve_dynptr(&ringbuf, sizeof(*sample), 0, &ptr2); sample = bpf_dynptr_data(&ptr1, 0, sizeof(*sample)); if (!sample) { bpf_ringbuf_discard_dynptr(&ptr1, 0); bpf_ringbuf_discard_dynptr(&ptr2, 0); return 0; } bpf_ringbuf_submit_dynptr(&ptr1, 0); /* missing a call to bpf_ringbuf_discard/submit_dynptr on ptr2 */ return 0; } static int missing_release_callback_fn(__u32 index, void *data) { struct bpf_dynptr ptr; bpf_ringbuf_reserve_dynptr(&ringbuf, val, 0, &ptr); /* missing a call to bpf_ringbuf_discard/submit_dynptr */ return 0; } /* Any dynptr initialized within a callback must have bpf_dynptr_put called */ SEC("?raw_tp") __failure __msg("Unreleased reference id") int ringbuf_missing_release_callback(void *ctx) { bpf_loop(10, missing_release_callback_fn, NULL, 0); return 0; } /* Can't call bpf_ringbuf_submit/discard_dynptr on a non-initialized dynptr */ SEC("?raw_tp") __failure __msg("arg 1 is an unacquired reference") int ringbuf_release_uninit_dynptr(void *ctx) { struct bpf_dynptr ptr; /* this should fail */ bpf_ringbuf_submit_dynptr(&ptr, 0); return 0; } /* A dynptr can't be used after it has been invalidated */ SEC("?raw_tp") __failure __msg("Expected an initialized dynptr as arg #3") int use_after_invalid(void *ctx) { struct bpf_dynptr ptr; char read_data[64]; bpf_ringbuf_reserve_dynptr(&ringbuf, sizeof(read_data), 0, &ptr); bpf_dynptr_read(read_data, sizeof(read_data), &ptr, 0, 0); bpf_ringbuf_submit_dynptr(&ptr, 0); /* this should fail */ bpf_dynptr_read(read_data, sizeof(read_data), &ptr, 0, 0); return 0; } /* Can't call non-dynptr ringbuf APIs on a dynptr ringbuf sample */ SEC("?raw_tp") __failure __msg("type=mem expected=ringbuf_mem") int ringbuf_invalid_api(void *ctx) { struct bpf_dynptr ptr; struct sample *sample; bpf_ringbuf_reserve_dynptr(&ringbuf, sizeof(*sample), 0, &ptr); sample = bpf_dynptr_data(&ptr, 0, sizeof(*sample)); if (!sample) goto done; sample->pid = 123; /* invalid API use. need to use dynptr API to submit/discard */ bpf_ringbuf_submit(sample, 0); done: bpf_ringbuf_discard_dynptr(&ptr, 0); return 0; } /* Can't add a dynptr to a map */ SEC("?raw_tp") __failure __msg("invalid indirect read from stack") int add_dynptr_to_map1(void *ctx) { struct bpf_dynptr ptr; int key = 0; bpf_ringbuf_reserve_dynptr(&ringbuf, val, 0, &ptr); /* this should fail */ bpf_map_update_elem(&array_map1, &key, &ptr, 0); bpf_ringbuf_submit_dynptr(&ptr, 0); return 0; } /* Can't add a struct with an embedded dynptr to a map */ SEC("?raw_tp") __failure __msg("invalid indirect read from stack") int add_dynptr_to_map2(void *ctx) { struct test_info x; int key = 0; bpf_ringbuf_reserve_dynptr(&ringbuf, val, 0, &x.ptr); /* this should fail */ bpf_map_update_elem(&array_map2, &key, &x, 0); bpf_ringbuf_submit_dynptr(&x.ptr, 0); return 0; } /* A data slice can't be accessed out of bounds */ SEC("?raw_tp") __failure __msg("value is outside of the allowed memory range") int data_slice_out_of_bounds_ringbuf(void *ctx) { struct bpf_dynptr ptr; void *data; bpf_ringbuf_reserve_dynptr(&ringbuf, 8, 0, &ptr); data = bpf_dynptr_data(&ptr, 0, 8); if (!data) goto done; /* can't index out of bounds of the data slice */ val = *((char *)data + 8); done: bpf_ringbuf_submit_dynptr(&ptr, 0); return 0; } /* A data slice can't be accessed out of bounds */ SEC("?tc") __failure __msg("value is outside of the allowed memory range") int data_slice_out_of_bounds_skb(struct __sk_buff *skb) { struct bpf_dynptr ptr; struct ethhdr *hdr; char buffer[sizeof(*hdr)] = {}; bpf_dynptr_from_skb(skb, 0, &ptr); hdr = bpf_dynptr_slice_rdwr(&ptr, 0, buffer, sizeof(buffer)); if (!hdr) return SK_DROP; /* this should fail */ *(__u8*)(hdr + 1) = 1; return SK_PASS; } SEC("?raw_tp") __failure __msg("value is outside of the allowed memory range") int data_slice_out_of_bounds_map_value(void *ctx) { __u32 map_val; struct bpf_dynptr ptr; void *data; get_map_val_dynptr(&ptr); data = bpf_dynptr_data(&ptr, 0, sizeof(map_val)); if (!data) return 0; /* can't index out of bounds of the data slice */ val = *((char *)data + (sizeof(map_val) + 1)); return 0; } /* A data slice can't be used after it has been released */ SEC("?raw_tp") __failure __msg("invalid mem access 'scalar'") int data_slice_use_after_release1(void *ctx) { struct bpf_dynptr ptr; struct sample *sample; bpf_ringbuf_reserve_dynptr(&ringbuf, sizeof(*sample), 0, &ptr); sample = bpf_dynptr_data(&ptr, 0, sizeof(*sample)); if (!sample) goto done; sample->pid = 123; bpf_ringbuf_submit_dynptr(&ptr, 0); /* this should fail */ val = sample->pid; return 0; done: bpf_ringbuf_discard_dynptr(&ptr, 0); return 0; } /* A data slice can't be used after it has been released. * * This tests the case where the data slice tracks a dynptr (ptr2) * that is at a non-zero offset from the frame pointer (ptr1 is at fp, * ptr2 is at fp - 16). */ SEC("?raw_tp") __failure __msg("invalid mem access 'scalar'") int data_slice_use_after_release2(void *ctx) { struct bpf_dynptr ptr1, ptr2; struct sample *sample; bpf_ringbuf_reserve_dynptr(&ringbuf, 64, 0, &ptr1); bpf_ringbuf_reserve_dynptr(&ringbuf, sizeof(*sample), 0, &ptr2); sample = bpf_dynptr_data(&ptr2, 0, sizeof(*sample)); if (!sample) goto done; sample->pid = 23; bpf_ringbuf_submit_dynptr(&ptr2, 0); /* this should fail */ sample->pid = 23; bpf_ringbuf_submit_dynptr(&ptr1, 0); return 0; done: bpf_ringbuf_discard_dynptr(&ptr2, 0); bpf_ringbuf_discard_dynptr(&ptr1, 0); return 0; } /* A data slice must be first checked for NULL */ SEC("?raw_tp") __failure __msg("invalid mem access 'mem_or_null'") int data_slice_missing_null_check1(void *ctx) { struct bpf_dynptr ptr; void *data; bpf_ringbuf_reserve_dynptr(&ringbuf, 8, 0, &ptr); data = bpf_dynptr_data(&ptr, 0, 8); /* missing if (!data) check */ /* this should fail */ *(__u8 *)data = 3; bpf_ringbuf_submit_dynptr(&ptr, 0); return 0; } /* A data slice can't be dereferenced if it wasn't checked for null */ SEC("?raw_tp") __failure __msg("invalid mem access 'mem_or_null'") int data_slice_missing_null_check2(void *ctx) { struct bpf_dynptr ptr; __u64 *data1, *data2; bpf_ringbuf_reserve_dynptr(&ringbuf, 16, 0, &ptr); data1 = bpf_dynptr_data(&ptr, 0, 8); data2 = bpf_dynptr_data(&ptr, 0, 8); if (data1) /* this should fail */ *data2 = 3; bpf_ringbuf_discard_dynptr(&ptr, 0); return 0; } /* Can't pass in a dynptr as an arg to a helper function that doesn't take in a * dynptr argument */ SEC("?raw_tp") __failure __msg("invalid indirect read from stack") int invalid_helper1(void *ctx) { struct bpf_dynptr ptr; get_map_val_dynptr(&ptr); /* this should fail */ bpf_strncmp((const char *)&ptr, sizeof(ptr), "hello!"); return 0; } /* A dynptr can't be passed into a helper function at a non-zero offset */ SEC("?raw_tp") __failure __msg("cannot pass in dynptr at an offset=-8") int invalid_helper2(void *ctx) { struct bpf_dynptr ptr; char read_data[64]; get_map_val_dynptr(&ptr); /* this should fail */ bpf_dynptr_read(read_data, sizeof(read_data), (void *)&ptr + 8, 0, 0); return 0; } /* A bpf_dynptr is invalidated if it's been written into */ SEC("?raw_tp") __failure __msg("Expected an initialized dynptr as arg #1") int invalid_write1(void *ctx) { struct bpf_dynptr ptr; void *data; __u8 x = 0; get_map_val_dynptr(&ptr); memcpy(&ptr, &x, sizeof(x)); /* this should fail */ data = bpf_dynptr_data(&ptr, 0, 1); __sink(data); return 0; } /* * A bpf_dynptr can't be used as a dynptr if it has been written into at a fixed * offset */ SEC("?raw_tp") __failure __msg("cannot overwrite referenced dynptr") int invalid_write2(void *ctx) { struct bpf_dynptr ptr; char read_data[64]; __u8 x = 0; bpf_ringbuf_reserve_dynptr(&ringbuf, 64, 0, &ptr); memcpy((void *)&ptr + 8, &x, sizeof(x)); /* this should fail */ bpf_dynptr_read(read_data, sizeof(read_data), &ptr, 0, 0); bpf_ringbuf_submit_dynptr(&ptr, 0); return 0; } /* * A bpf_dynptr can't be used as a dynptr if it has been written into at a * non-const offset */ SEC("?raw_tp") __failure __msg("cannot overwrite referenced dynptr") int invalid_write3(void *ctx) { struct bpf_dynptr ptr; char stack_buf[16]; unsigned long len; __u8 x = 0; bpf_ringbuf_reserve_dynptr(&ringbuf, 8, 0, &ptr); memcpy(stack_buf, &val, sizeof(val)); len = stack_buf[0] & 0xf; memcpy((void *)&ptr + len, &x, sizeof(x)); /* this should fail */ bpf_ringbuf_submit_dynptr(&ptr, 0); return 0; } static int invalid_write4_callback(__u32 index, void *data) { *(__u32 *)data = 123; return 0; } /* If the dynptr is written into in a callback function, it should * be invalidated as a dynptr */ SEC("?raw_tp") __failure __msg("cannot overwrite referenced dynptr") int invalid_write4(void *ctx) { struct bpf_dynptr ptr; bpf_ringbuf_reserve_dynptr(&ringbuf, 64, 0, &ptr); bpf_loop(10, invalid_write4_callback, &ptr, 0); /* this should fail */ bpf_ringbuf_submit_dynptr(&ptr, 0); return 0; } /* A globally-defined bpf_dynptr can't be used (it must reside as a stack frame) */ struct bpf_dynptr global_dynptr; SEC("?raw_tp") __failure __msg("type=map_value expected=fp") int global(void *ctx) { /* this should fail */ bpf_ringbuf_reserve_dynptr(&ringbuf, 16, 0, &global_dynptr); bpf_ringbuf_discard_dynptr(&global_dynptr, 0); return 0; } /* A direct read should fail */ SEC("?raw_tp") __failure __msg("invalid read from stack") int invalid_read1(void *ctx) { struct bpf_dynptr ptr; bpf_ringbuf_reserve_dynptr(&ringbuf, 64, 0, &ptr); /* this should fail */ val = *(int *)&ptr; bpf_ringbuf_discard_dynptr(&ptr, 0); return 0; } /* A direct read at an offset should fail */ SEC("?raw_tp") __failure __msg("cannot pass in dynptr at an offset") int invalid_read2(void *ctx) { struct bpf_dynptr ptr; char read_data[64]; get_map_val_dynptr(&ptr); /* this should fail */ bpf_dynptr_read(read_data, sizeof(read_data), (void *)&ptr + 1, 0, 0); return 0; } /* A direct read at an offset into the lower stack slot should fail */ SEC("?raw_tp") __failure __msg("invalid read from stack") int invalid_read3(void *ctx) { struct bpf_dynptr ptr1, ptr2; bpf_ringbuf_reserve_dynptr(&ringbuf, 16, 0, &ptr1); bpf_ringbuf_reserve_dynptr(&ringbuf, 16, 0, &ptr2); /* this should fail */ memcpy(&val, (void *)&ptr1 + 8, sizeof(val)); bpf_ringbuf_discard_dynptr(&ptr1, 0); bpf_ringbuf_discard_dynptr(&ptr2, 0); return 0; } static int invalid_read4_callback(__u32 index, void *data) { /* this should fail */ val = *(__u32 *)data; return 0; } /* A direct read within a callback function should fail */ SEC("?raw_tp") __failure __msg("invalid read from stack") int invalid_read4(void *ctx) { struct bpf_dynptr ptr; bpf_ringbuf_reserve_dynptr(&ringbuf, 64, 0, &ptr); bpf_loop(10, invalid_read4_callback, &ptr, 0); bpf_ringbuf_submit_dynptr(&ptr, 0); return 0; } /* Initializing a dynptr on an offset should fail */ SEC("?raw_tp") __failure __msg("cannot pass in dynptr at an offset=0") int invalid_offset(void *ctx) { struct bpf_dynptr ptr; /* this should fail */ bpf_ringbuf_reserve_dynptr(&ringbuf, 64, 0, &ptr + 1); bpf_ringbuf_discard_dynptr(&ptr, 0); return 0; } /* Can't release a dynptr twice */ SEC("?raw_tp") __failure __msg("arg 1 is an unacquired reference") int release_twice(void *ctx) { struct bpf_dynptr ptr; bpf_ringbuf_reserve_dynptr(&ringbuf, 16, 0, &ptr); bpf_ringbuf_discard_dynptr(&ptr, 0); /* this second release should fail */ bpf_ringbuf_discard_dynptr(&ptr, 0); return 0; } static int release_twice_callback_fn(__u32 index, void *data) { /* this should fail */ bpf_ringbuf_discard_dynptr(data, 0); return 0; } /* Test that releasing a dynptr twice, where one of the releases happens * within a callback function, fails */ SEC("?raw_tp") __failure __msg("arg 1 is an unacquired reference") int release_twice_callback(void *ctx) { struct bpf_dynptr ptr; bpf_ringbuf_reserve_dynptr(&ringbuf, 32, 0, &ptr); bpf_ringbuf_discard_dynptr(&ptr, 0); bpf_loop(10, release_twice_callback_fn, &ptr, 0); return 0; } /* Reject unsupported local mem types for dynptr_from_mem API */ SEC("?raw_tp") __failure __msg("Unsupported reg type fp for bpf_dynptr_from_mem data") int dynptr_from_mem_invalid_api(void *ctx) { struct bpf_dynptr ptr; int x = 0; /* this should fail */ bpf_dynptr_from_mem(&x, sizeof(x), 0, &ptr); return 0; } SEC("?tc") __failure __msg("cannot overwrite referenced dynptr") __log_level(2) int dynptr_pruning_overwrite(struct __sk_buff *ctx) { asm volatile ( "r9 = 0xeB9F; \ r6 = %[ringbuf] ll; \ r1 = r6; \ r2 = 8; \ r3 = 0; \ r4 = r10; \ r4 += -16; \ call %[bpf_ringbuf_reserve_dynptr]; \ if r0 == 0 goto pjmp1; \ goto pjmp2; \ pjmp1: \ *(u64 *)(r10 - 16) = r9; \ pjmp2: \ r1 = r10; \ r1 += -16; \ r2 = 0; \ call %[bpf_ringbuf_discard_dynptr]; " : : __imm(bpf_ringbuf_reserve_dynptr), __imm(bpf_ringbuf_discard_dynptr), __imm_addr(ringbuf) : __clobber_all ); return 0; } SEC("?tc") __success __msg("12: safe") __log_level(2) int dynptr_pruning_stacksafe(struct __sk_buff *ctx) { asm volatile ( "r9 = 0xeB9F; \ r6 = %[ringbuf] ll; \ r1 = r6; \ r2 = 8; \ r3 = 0; \ r4 = r10; \ r4 += -16; \ call %[bpf_ringbuf_reserve_dynptr]; \ if r0 == 0 goto stjmp1; \ goto stjmp2; \ stjmp1: \ r9 = r9; \ stjmp2: \ r1 = r10; \ r1 += -16; \ r2 = 0; \ call %[bpf_ringbuf_discard_dynptr]; " : : __imm(bpf_ringbuf_reserve_dynptr), __imm(bpf_ringbuf_discard_dynptr), __imm_addr(ringbuf) : __clobber_all ); return 0; } SEC("?tc") __failure __msg("cannot overwrite referenced dynptr") __log_level(2) int dynptr_pruning_type_confusion(struct __sk_buff *ctx) { asm volatile ( "r6 = %[array_map4] ll; \ r7 = %[ringbuf] ll; \ r1 = r6; \ r2 = r10; \ r2 += -8; \ r9 = 0; \ *(u64 *)(r2 + 0) = r9; \ r3 = r10; \ r3 += -24; \ r9 = 0xeB9FeB9F; \ *(u64 *)(r10 - 16) = r9; \ *(u64 *)(r10 - 24) = r9; \ r9 = 0; \ r4 = 0; \ r8 = r2; \ call %[bpf_map_update_elem]; \ r1 = r6; \ r2 = r8; \ call %[bpf_map_lookup_elem]; \ if r0 != 0 goto tjmp1; \ exit; \ tjmp1: \ r8 = r0; \ r1 = r7; \ r2 = 8; \ r3 = 0; \ r4 = r10; \ r4 += -16; \ r0 = *(u64 *)(r0 + 0); \ call %[bpf_ringbuf_reserve_dynptr]; \ if r0 == 0 goto tjmp2; \ r8 = r8; \ r8 = r8; \ r8 = r8; \ r8 = r8; \ r8 = r8; \ r8 = r8; \ r8 = r8; \ goto tjmp3; \ tjmp2: \ *(u64 *)(r10 - 8) = r9; \ *(u64 *)(r10 - 16) = r9; \ r1 = r8; \ r1 += 8; \ r2 = 0; \ r3 = 0; \ r4 = r10; \ r4 += -16; \ call %[bpf_dynptr_from_mem]; \ tjmp3: \ r1 = r10; \ r1 += -16; \ r2 = 0; \ call %[bpf_ringbuf_discard_dynptr]; " : : __imm(bpf_map_update_elem), __imm(bpf_map_lookup_elem), __imm(bpf_ringbuf_reserve_dynptr), __imm(bpf_dynptr_from_mem), __imm(bpf_ringbuf_discard_dynptr), __imm_addr(array_map4), __imm_addr(ringbuf) : __clobber_all ); return 0; } SEC("?tc") __failure __msg("dynptr has to be at a constant offset") __log_level(2) int dynptr_var_off_overwrite(struct __sk_buff *ctx) { asm volatile ( "r9 = 16; \ *(u32 *)(r10 - 4) = r9; \ r8 = *(u32 *)(r10 - 4); \ if r8 >= 0 goto vjmp1; \ r0 = 1; \ exit; \ vjmp1: \ if r8 <= 16 goto vjmp2; \ r0 = 1; \ exit; \ vjmp2: \ r8 &= 16; \ r1 = %[ringbuf] ll; \ r2 = 8; \ r3 = 0; \ r4 = r10; \ r4 += -32; \ r4 += r8; \ call %[bpf_ringbuf_reserve_dynptr]; \ r9 = 0xeB9F; \ *(u64 *)(r10 - 16) = r9; \ r1 = r10; \ r1 += -32; \ r1 += r8; \ r2 = 0; \ call %[bpf_ringbuf_discard_dynptr]; " : : __imm(bpf_ringbuf_reserve_dynptr), __imm(bpf_ringbuf_discard_dynptr), __imm_addr(ringbuf) : __clobber_all ); return 0; } SEC("?tc") __failure __msg("cannot overwrite referenced dynptr") __log_level(2) int dynptr_partial_slot_invalidate(struct __sk_buff *ctx) { asm volatile ( "r6 = %[ringbuf] ll; \ r7 = %[array_map4] ll; \ r1 = r7; \ r2 = r10; \ r2 += -8; \ r9 = 0; \ *(u64 *)(r2 + 0) = r9; \ r3 = r2; \ r4 = 0; \ r8 = r2; \ call %[bpf_map_update_elem]; \ r1 = r7; \ r2 = r8; \ call %[bpf_map_lookup_elem]; \ if r0 != 0 goto sjmp1; \ exit; \ sjmp1: \ r7 = r0; \ r1 = r6; \ r2 = 8; \ r3 = 0; \ r4 = r10; \ r4 += -24; \ call %[bpf_ringbuf_reserve_dynptr]; \ *(u64 *)(r10 - 16) = r9; \ r1 = r7; \ r2 = 8; \ r3 = 0; \ r4 = r10; \ r4 += -16; \ call %[bpf_dynptr_from_mem]; \ r1 = r10; \ r1 += -512; \ r2 = 488; \ r3 = r10; \ r3 += -24; \ r4 = 0; \ r5 = 0; \ call %[bpf_dynptr_read]; \ r8 = 1; \ if r0 != 0 goto sjmp2; \ r8 = 0; \ sjmp2: \ r1 = r10; \ r1 += -24; \ r2 = 0; \ call %[bpf_ringbuf_discard_dynptr]; " : : __imm(bpf_map_update_elem), __imm(bpf_map_lookup_elem), __imm(bpf_ringbuf_reserve_dynptr), __imm(bpf_ringbuf_discard_dynptr), __imm(bpf_dynptr_from_mem), __imm(bpf_dynptr_read), __imm_addr(ringbuf), __imm_addr(array_map4) : __clobber_all ); return 0; } /* Test that it is allowed to overwrite unreferenced dynptr. */ SEC("?raw_tp") __success int dynptr_overwrite_unref(void *ctx) { struct bpf_dynptr ptr; if (get_map_val_dynptr(&ptr)) return 0; if (get_map_val_dynptr(&ptr)) return 0; if (get_map_val_dynptr(&ptr)) return 0; return 0; } /* Test that slices are invalidated on reinitializing a dynptr. */ SEC("?raw_tp") __failure __msg("invalid mem access 'scalar'") int dynptr_invalidate_slice_reinit(void *ctx) { struct bpf_dynptr ptr; __u8 *p; if (get_map_val_dynptr(&ptr)) return 0; p = bpf_dynptr_data(&ptr, 0, 1); if (!p) return 0; if (get_map_val_dynptr(&ptr)) return 0; /* this should fail */ return *p; } /* Invalidation of dynptr slices on destruction of dynptr should not miss * mem_or_null pointers. */ SEC("?raw_tp") __failure __regex("R[0-9]+ type=scalar expected=percpu_ptr_") int dynptr_invalidate_slice_or_null(void *ctx) { struct bpf_dynptr ptr; __u8 *p; if (get_map_val_dynptr(&ptr)) return 0; p = bpf_dynptr_data(&ptr, 0, 1); *(__u8 *)&ptr = 0; /* this should fail */ bpf_this_cpu_ptr(p); return 0; } /* Destruction of dynptr should also any slices obtained from it */ SEC("?raw_tp") __failure __regex("R[0-9]+ invalid mem access 'scalar'") int dynptr_invalidate_slice_failure(void *ctx) { struct bpf_dynptr ptr1; struct bpf_dynptr ptr2; __u8 *p1, *p2; if (get_map_val_dynptr(&ptr1)) return 0; if (get_map_val_dynptr(&ptr2)) return 0; p1 = bpf_dynptr_data(&ptr1, 0, 1); if (!p1) return 0; p2 = bpf_dynptr_data(&ptr2, 0, 1); if (!p2) return 0; *(__u8 *)&ptr1 = 0; /* this should fail */ return *p1; } /* Invalidation of slices should be scoped and should not prevent dereferencing * slices of another dynptr after destroying unrelated dynptr */ SEC("?raw_tp") __success int dynptr_invalidate_slice_success(void *ctx) { struct bpf_dynptr ptr1; struct bpf_dynptr ptr2; __u8 *p1, *p2; if (get_map_val_dynptr(&ptr1)) return 1; if (get_map_val_dynptr(&ptr2)) return 1; p1 = bpf_dynptr_data(&ptr1, 0, 1); if (!p1) return 1; p2 = bpf_dynptr_data(&ptr2, 0, 1); if (!p2) return 1; *(__u8 *)&ptr1 = 0; return *p2; } /* Overwriting referenced dynptr should be rejected */ SEC("?raw_tp") __failure __msg("cannot overwrite referenced dynptr") int dynptr_overwrite_ref(void *ctx) { struct bpf_dynptr ptr; bpf_ringbuf_reserve_dynptr(&ringbuf, 64, 0, &ptr); /* this should fail */ if (get_map_val_dynptr(&ptr)) bpf_ringbuf_discard_dynptr(&ptr, 0); return 0; } /* Reject writes to dynptr slot from bpf_dynptr_read */ SEC("?raw_tp") __failure __msg("potential write to dynptr at off=-16") int dynptr_read_into_slot(void *ctx) { union { struct { char _pad[48]; struct bpf_dynptr ptr; }; char buf[64]; } data; bpf_ringbuf_reserve_dynptr(&ringbuf, 64, 0, &data.ptr); /* this should fail */ bpf_dynptr_read(data.buf, sizeof(data.buf), &data.ptr, 0, 0); return 0; } /* bpf_dynptr_slice()s are read-only and cannot be written to */ SEC("?tc") __failure __regex("R[0-9]+ cannot write into rdonly_mem") int skb_invalid_slice_write(struct __sk_buff *skb) { struct bpf_dynptr ptr; struct ethhdr *hdr; char buffer[sizeof(*hdr)] = {}; bpf_dynptr_from_skb(skb, 0, &ptr); hdr = bpf_dynptr_slice(&ptr, 0, buffer, sizeof(buffer)); if (!hdr) return SK_DROP; /* this should fail */ hdr->h_proto = 1; return SK_PASS; } /* The read-only data slice is invalidated whenever a helper changes packet data */ SEC("?tc") __failure __msg("invalid mem access 'scalar'") int skb_invalid_data_slice1(struct __sk_buff *skb) { struct bpf_dynptr ptr; struct ethhdr *hdr; char buffer[sizeof(*hdr)] = {}; bpf_dynptr_from_skb(skb, 0, &ptr); hdr = bpf_dynptr_slice(&ptr, 0, buffer, sizeof(buffer)); if (!hdr) return SK_DROP; val = hdr->h_proto; if (bpf_skb_pull_data(skb, skb->len)) return SK_DROP; /* this should fail */ val = hdr->h_proto; return SK_PASS; } /* The read-write data slice is invalidated whenever a helper changes packet data */ SEC("?tc") __failure __msg("invalid mem access 'scalar'") int skb_invalid_data_slice2(struct __sk_buff *skb) { struct bpf_dynptr ptr; struct ethhdr *hdr; char buffer[sizeof(*hdr)] = {}; bpf_dynptr_from_skb(skb, 0, &ptr); hdr = bpf_dynptr_slice_rdwr(&ptr, 0, buffer, sizeof(buffer)); if (!hdr) return SK_DROP; hdr->h_proto = 123; if (bpf_skb_pull_data(skb, skb->len)) return SK_DROP; /* this should fail */ hdr->h_proto = 1; return SK_PASS; } /* The read-only data slice is invalidated whenever bpf_dynptr_write() is called */ SEC("?tc") __failure __msg("invalid mem access 'scalar'") int skb_invalid_data_slice3(struct __sk_buff *skb) { char write_data[64] = "hello there, world!!"; struct bpf_dynptr ptr; struct ethhdr *hdr; char buffer[sizeof(*hdr)] = {}; bpf_dynptr_from_skb(skb, 0, &ptr); hdr = bpf_dynptr_slice(&ptr, 0, buffer, sizeof(buffer)); if (!hdr) return SK_DROP; val = hdr->h_proto; bpf_dynptr_write(&ptr, 0, write_data, sizeof(write_data), 0); /* this should fail */ val = hdr->h_proto; return SK_PASS; } /* The read-write data slice is invalidated whenever bpf_dynptr_write() is called */ SEC("?tc") __failure __msg("invalid mem access 'scalar'") int skb_invalid_data_slice4(struct __sk_buff *skb) { char write_data[64] = "hello there, world!!"; struct bpf_dynptr ptr; struct ethhdr *hdr; char buffer[sizeof(*hdr)] = {}; bpf_dynptr_from_skb(skb, 0, &ptr); hdr = bpf_dynptr_slice_rdwr(&ptr, 0, buffer, sizeof(buffer)); if (!hdr) return SK_DROP; hdr->h_proto = 123; bpf_dynptr_write(&ptr, 0, write_data, sizeof(write_data), 0); /* this should fail */ hdr->h_proto = 1; return SK_PASS; } /* The read-only data slice is invalidated whenever a helper changes packet data */ SEC("?xdp") __failure __msg("invalid mem access 'scalar'") int xdp_invalid_data_slice1(struct xdp_md *xdp) { struct bpf_dynptr ptr; struct ethhdr *hdr; char buffer[sizeof(*hdr)] = {}; bpf_dynptr_from_xdp(xdp, 0, &ptr); hdr = bpf_dynptr_slice(&ptr, 0, buffer, sizeof(buffer)); if (!hdr) return SK_DROP; val = hdr->h_proto; if (bpf_xdp_adjust_head(xdp, 0 - (int)sizeof(*hdr))) return XDP_DROP; /* this should fail */ val = hdr->h_proto; return XDP_PASS; } /* The read-write data slice is invalidated whenever a helper changes packet data */ SEC("?xdp") __failure __msg("invalid mem access 'scalar'") int xdp_invalid_data_slice2(struct xdp_md *xdp) { struct bpf_dynptr ptr; struct ethhdr *hdr; char buffer[sizeof(*hdr)] = {}; bpf_dynptr_from_xdp(xdp, 0, &ptr); hdr = bpf_dynptr_slice_rdwr(&ptr, 0, buffer, sizeof(buffer)); if (!hdr) return SK_DROP; hdr->h_proto = 9; if (bpf_xdp_adjust_head(xdp, 0 - (int)sizeof(*hdr))) return XDP_DROP; /* this should fail */ hdr->h_proto = 1; return XDP_PASS; } /* Only supported prog type can create skb-type dynptrs */ SEC("?raw_tp") __failure __msg("calling kernel function bpf_dynptr_from_skb is not allowed") int skb_invalid_ctx(void *ctx) { struct bpf_dynptr ptr; /* this should fail */ bpf_dynptr_from_skb(ctx, 0, &ptr); return 0; } /* Reject writes to dynptr slot for uninit arg */ SEC("?raw_tp") __failure __msg("potential write to dynptr at off=-16") int uninit_write_into_slot(void *ctx) { struct { char buf[64]; struct bpf_dynptr ptr; } data; bpf_ringbuf_reserve_dynptr(&ringbuf, 80, 0, &data.ptr); /* this should fail */ bpf_get_current_comm(data.buf, 80); return 0; } /* Only supported prog type can create xdp-type dynptrs */ SEC("?raw_tp") __failure __msg("calling kernel function bpf_dynptr_from_xdp is not allowed") int xdp_invalid_ctx(void *ctx) { struct bpf_dynptr ptr; /* this should fail */ bpf_dynptr_from_xdp(ctx, 0, &ptr); return 0; } __u32 hdr_size = sizeof(struct ethhdr); /* Can't pass in variable-sized len to bpf_dynptr_slice */ SEC("?tc") __failure __msg("unbounded memory access") int dynptr_slice_var_len1(struct __sk_buff *skb) { struct bpf_dynptr ptr; struct ethhdr *hdr; char buffer[sizeof(*hdr)] = {}; bpf_dynptr_from_skb(skb, 0, &ptr); /* this should fail */ hdr = bpf_dynptr_slice(&ptr, 0, buffer, hdr_size); if (!hdr) return SK_DROP; return SK_PASS; } /* Can't pass in variable-sized len to bpf_dynptr_slice */ SEC("?tc") __failure __msg("must be a known constant") int dynptr_slice_var_len2(struct __sk_buff *skb) { char buffer[sizeof(struct ethhdr)] = {}; struct bpf_dynptr ptr; struct ethhdr *hdr; bpf_dynptr_from_skb(skb, 0, &ptr); if (hdr_size <= sizeof(buffer)) { /* this should fail */ hdr = bpf_dynptr_slice_rdwr(&ptr, 0, buffer, hdr_size); if (!hdr) return SK_DROP; hdr->h_proto = 12; } return SK_PASS; } static int callback(__u32 index, void *data) { *(__u32 *)data = 123; return 0; } /* If the dynptr is written into in a callback function, its data * slices should be invalidated as well. */ SEC("?raw_tp") __failure __msg("invalid mem access 'scalar'") int invalid_data_slices(void *ctx) { struct bpf_dynptr ptr; __u32 *slice; if (get_map_val_dynptr(&ptr)) return 0; slice = bpf_dynptr_data(&ptr, 0, sizeof(__u32)); if (!slice) return 0; bpf_loop(10, callback, &ptr, 0); /* this should fail */ *slice = 1; return 0; } /* Program types that don't allow writes to packet data should fail if * bpf_dynptr_slice_rdwr is called */ SEC("cgroup_skb/ingress") __failure __msg("the prog does not allow writes to packet data") int invalid_slice_rdwr_rdonly(struct __sk_buff *skb) { char buffer[sizeof(struct ethhdr)] = {}; struct bpf_dynptr ptr; struct ethhdr *hdr; bpf_dynptr_from_skb(skb, 0, &ptr); /* this should fail since cgroup_skb doesn't allow * changing packet data */ hdr = bpf_dynptr_slice_rdwr(&ptr, 0, buffer, sizeof(buffer)); __sink(hdr); return 0; } /* bpf_dynptr_adjust can only be called on initialized dynptrs */ SEC("?raw_tp") __failure __msg("Expected an initialized dynptr as arg #1") int dynptr_adjust_invalid(void *ctx) { struct bpf_dynptr ptr = {}; /* this should fail */ bpf_dynptr_adjust(&ptr, 1, 2); return 0; } /* bpf_dynptr_is_null can only be called on initialized dynptrs */ SEC("?raw_tp") __failure __msg("Expected an initialized dynptr as arg #1") int dynptr_is_null_invalid(void *ctx) { struct bpf_dynptr ptr = {}; /* this should fail */ bpf_dynptr_is_null(&ptr); return 0; } /* bpf_dynptr_is_rdonly can only be called on initialized dynptrs */ SEC("?raw_tp") __failure __msg("Expected an initialized dynptr as arg #1") int dynptr_is_rdonly_invalid(void *ctx) { struct bpf_dynptr ptr = {}; /* this should fail */ bpf_dynptr_is_rdonly(&ptr); return 0; } /* bpf_dynptr_size can only be called on initialized dynptrs */ SEC("?raw_tp") __failure __msg("Expected an initialized dynptr as arg #1") int dynptr_size_invalid(void *ctx) { struct bpf_dynptr ptr = {}; /* this should fail */ bpf_dynptr_size(&ptr); return 0; } /* Only initialized dynptrs can be cloned */ SEC("?raw_tp") __failure __msg("Expected an initialized dynptr as arg #1") int clone_invalid1(void *ctx) { struct bpf_dynptr ptr1 = {}; struct bpf_dynptr ptr2; /* this should fail */ bpf_dynptr_clone(&ptr1, &ptr2); return 0; } /* Can't overwrite an existing dynptr when cloning */ SEC("?xdp") __failure __msg("cannot overwrite referenced dynptr") int clone_invalid2(struct xdp_md *xdp) { struct bpf_dynptr ptr1; struct bpf_dynptr clone; bpf_dynptr_from_xdp(xdp, 0, &ptr1); bpf_ringbuf_reserve_dynptr(&ringbuf, 64, 0, &clone); /* this should fail */ bpf_dynptr_clone(&ptr1, &clone); bpf_ringbuf_submit_dynptr(&clone, 0); return 0; } /* Invalidating a dynptr should invalidate its clones */ SEC("?raw_tp") __failure __msg("Expected an initialized dynptr as arg #3") int clone_invalidate1(void *ctx) { struct bpf_dynptr clone; struct bpf_dynptr ptr; char read_data[64]; bpf_ringbuf_reserve_dynptr(&ringbuf, val, 0, &ptr); bpf_dynptr_clone(&ptr, &clone); bpf_ringbuf_submit_dynptr(&ptr, 0); /* this should fail */ bpf_dynptr_read(read_data, sizeof(read_data), &clone, 0, 0); return 0; } /* Invalidating a dynptr should invalidate its parent */ SEC("?raw_tp") __failure __msg("Expected an initialized dynptr as arg #3") int clone_invalidate2(void *ctx) { struct bpf_dynptr ptr; struct bpf_dynptr clone; char read_data[64]; bpf_ringbuf_reserve_dynptr(&ringbuf, val, 0, &ptr); bpf_dynptr_clone(&ptr, &clone); bpf_ringbuf_submit_dynptr(&clone, 0); /* this should fail */ bpf_dynptr_read(read_data, sizeof(read_data), &ptr, 0, 0); return 0; } /* Invalidating a dynptr should invalidate its siblings */ SEC("?raw_tp") __failure __msg("Expected an initialized dynptr as arg #3") int clone_invalidate3(void *ctx) { struct bpf_dynptr ptr; struct bpf_dynptr clone1; struct bpf_dynptr clone2; char read_data[64]; bpf_ringbuf_reserve_dynptr(&ringbuf, val, 0, &ptr); bpf_dynptr_clone(&ptr, &clone1); bpf_dynptr_clone(&ptr, &clone2); bpf_ringbuf_submit_dynptr(&clone2, 0); /* this should fail */ bpf_dynptr_read(read_data, sizeof(read_data), &clone1, 0, 0); return 0; } /* Invalidating a dynptr should invalidate any data slices * of its clones */ SEC("?raw_tp") __failure __msg("invalid mem access 'scalar'") int clone_invalidate4(void *ctx) { struct bpf_dynptr ptr; struct bpf_dynptr clone; int *data; bpf_ringbuf_reserve_dynptr(&ringbuf, val, 0, &ptr); bpf_dynptr_clone(&ptr, &clone); data = bpf_dynptr_data(&clone, 0, sizeof(val)); if (!data) return 0; bpf_ringbuf_submit_dynptr(&ptr, 0); /* this should fail */ *data = 123; return 0; } /* Invalidating a dynptr should invalidate any data slices * of its parent */ SEC("?raw_tp") __failure __msg("invalid mem access 'scalar'") int clone_invalidate5(void *ctx) { struct bpf_dynptr ptr; struct bpf_dynptr clone; int *data; bpf_ringbuf_reserve_dynptr(&ringbuf, val, 0, &ptr); data = bpf_dynptr_data(&ptr, 0, sizeof(val)); if (!data) return 0; bpf_dynptr_clone(&ptr, &clone); bpf_ringbuf_submit_dynptr(&clone, 0); /* this should fail */ *data = 123; return 0; } /* Invalidating a dynptr should invalidate any data slices * of its sibling */ SEC("?raw_tp") __failure __msg("invalid mem access 'scalar'") int clone_invalidate6(void *ctx) { struct bpf_dynptr ptr; struct bpf_dynptr clone1; struct bpf_dynptr clone2; int *data; bpf_ringbuf_reserve_dynptr(&ringbuf, val, 0, &ptr); bpf_dynptr_clone(&ptr, &clone1); bpf_dynptr_clone(&ptr, &clone2); data = bpf_dynptr_data(&clone1, 0, sizeof(val)); if (!data) return 0; bpf_ringbuf_submit_dynptr(&clone2, 0); /* this should fail */ *data = 123; return 0; } /* A skb clone's data slices should be invalid anytime packet data changes */ SEC("?tc") __failure __msg("invalid mem access 'scalar'") int clone_skb_packet_data(struct __sk_buff *skb) { char buffer[sizeof(__u32)] = {}; struct bpf_dynptr clone; struct bpf_dynptr ptr; __u32 *data; bpf_dynptr_from_skb(skb, 0, &ptr); bpf_dynptr_clone(&ptr, &clone); data = bpf_dynptr_slice_rdwr(&clone, 0, buffer, sizeof(buffer)); if (!data) return XDP_DROP; if (bpf_skb_pull_data(skb, skb->len)) return SK_DROP; /* this should fail */ *data = 123; return 0; } /* A xdp clone's data slices should be invalid anytime packet data changes */ SEC("?xdp") __failure __msg("invalid mem access 'scalar'") int clone_xdp_packet_data(struct xdp_md *xdp) { char buffer[sizeof(__u32)] = {}; struct bpf_dynptr clone; struct bpf_dynptr ptr; struct ethhdr *hdr; __u32 *data; bpf_dynptr_from_xdp(xdp, 0, &ptr); bpf_dynptr_clone(&ptr, &clone); data = bpf_dynptr_slice_rdwr(&clone, 0, buffer, sizeof(buffer)); if (!data) return XDP_DROP; if (bpf_xdp_adjust_head(xdp, 0 - (int)sizeof(*hdr))) return XDP_DROP; /* this should fail */ *data = 123; return 0; } /* Buffers that are provided must be sufficiently long */ SEC("?cgroup_skb/egress") __failure __msg("memory, len pair leads to invalid memory access") int test_dynptr_skb_small_buff(struct __sk_buff *skb) { struct bpf_dynptr ptr; char buffer[8] = {}; __u64 *data; if (bpf_dynptr_from_skb(skb, 0, &ptr)) { err = 1; return 1; } /* This may return NULL. SKB may require a buffer */ data = bpf_dynptr_slice(&ptr, 0, buffer, 9); return !!data; } __noinline long global_call_bpf_dynptr(const struct bpf_dynptr *dynptr) { long ret = 0; /* Avoid leaving this global function empty to avoid having the compiler * optimize away the call to this global function. */ __sink(ret); return ret; } SEC("?raw_tp") __failure __msg("arg#1 expected pointer to stack or const struct bpf_dynptr") int test_dynptr_reg_type(void *ctx) { struct task_struct *current = NULL; /* R1 should be holding a PTR_TO_BTF_ID, so this shouldn't be a * reg->type that can be passed to a function accepting a * ARG_PTR_TO_DYNPTR | MEM_RDONLY. process_dynptr_func() should catch * this. */ global_call_bpf_dynptr((const struct bpf_dynptr *)current); return 0; } |